linux-kernel - Re: [PATCH] Split out some macro's and move common code to paranoid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Nov 2008 17:06:29 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Alexander van Heukelum <heukelum@...lshack.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Jan Beulich <jbeulich@...ell.com>,
	Glauber Costa <gcosta@...hat.com>,
	Matt Mackall <mpm@...enic.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	Cyrill Gorcunov <gorcunov@...il.com>
Subject: Re: [PATCH] Split out some macro's and move common code to
	paranoid_exit


* Alexander van Heukelum <heukelum@...lshack.com> wrote:

>  	/* runs on exception stack */
>  ENTRY(stack_segment)
> -	XCPT_FRAME
> -	PARAVIRT_ADJUST_EXCEPTION_FRAME
> -	paranoidentry do_stack_segment
> -	jmp paranoid_exit
> -	CFI_ENDPROC
> +	paranoiderrorentry do_stack_segment
>  END(stack_segment)

cool!

Could you please also collapse it into just a single macro? The 
ENTRY/END sequence can be generated by the macro. (if you do it then 
please do it in a followup patch, i'll look at and apply your current 
series)

Something like:

  PARANOID_ERROR_ENTRY(stack_segment)

Could do all the magic, right?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/