linux-kernel - Re: [PATCH 24/45] CacheFiles: Add a hook to write a single page of data to an inode [ver #41]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Nov 2008 10:31:01 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
Cc:	trond.myklebust@....uio.no, viro@...IV.linux.org.uk,
	nfsv4@...ux-nfs.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>
Subject: Re: [PATCH 24/45] CacheFiles: Add a hook to write a single page of
 data to an inode [ver #41]

On Fri, 21 Nov 2008 12:43:41 +0000 David Howells <dhowells@...hat.com> wrote:

> > > +/**
> > > + * generic_file_buffered_write_one_page - Write a single page of data to an
> > > + *	inode
> > 
> > kerneldoc doesn't permit line breaks in this context (unless it got
> > fixed recently)
> 
> So you advocate a line exceeding 80 chars?

yup

> I contend that kerneldoc is a bad idea in many ways: it encourages people to
> be lazy and to not write proper interface documentation.

yes, for some reason kereldoc-formatted comments usually aren't very
useful.  They very often just don't convey useful insights.  I wonder
why.  Maybe people think that once they've filled out the form and
ticked all the boxes, they're done.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/