linux-kernel - Re: [PATCH 1/3] driver/net/*: remove redundant argument comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Nov 2008 00:10:03 -0800
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	qhfeng.kernel@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] driver/net/*: remove redundant argument comments

On Fri, Nov 21, 2008 at 11:56 PM, David Miller <davem@...emloft.net> wrote:
> From: "Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
> Date: Fri, 21 Nov 2008 23:55:27 -0800
>
>> I would agree that "@rx_ring: pointer to receive ring structure" is
>> probably not the best documentation, but rather than removing it, I
>> would suggest improving it.
>
> Jeff, he's removing it because the function no longer takes
> that argument any more.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

I apologize, based on the patch comment of "remove redundant argument
comments" I took that he was removing comments that were "unnecessary
and repetitive" and not referring to "non-existent arguments".

I rescind my Nak.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/