linux-kernel - Re: [PATCH 1/2] mfd: Switch WM8350 revision detection to a feature based model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 24 Nov 2008 20:25:32 +0100
From:	Samuel Ortiz <sameo@...nedhand.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: Switch WM8350 revision detection to a feature
	based model

On Mon, Nov 24, 2008 at 01:31:16PM +0000, Mark Brown wrote:
> On Mon, Nov 24, 2008 at 11:37:55AM +0100, Samuel Ortiz wrote:
> 
> > Dont you prefer to use the WM8350_REV_* values in your code rather than some
> > undocumented constants like that ?
> > I understand that reading the code below will make those constants obvious,
> > but still...
> 
> I don't find them enormously helpful, TBH - the constant gets used in
> exactly one place and there's been a bit of skew between what some of
> the ID registers are called and thier actual meaning which doesn't help.
> 
> I'll repost with the #defines for the revisons added back, though.
Thanks for the patches. Both of them are now sitting in my for-next branch.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/