linux-kernel - Re: [PATCH] fix similar typos to successfull, v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2008 16:48:14 +0800
From:	Coly Li <coyli@...e.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix similar typos to successfull, v2



Andrew Morton Wrote:
> On Tue, 25 Nov 2008 01:44:13 +0800
> Coly Li <coyli@...e.de> wrote:
> 
>> When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull "
>> in kernel tree, 22 typos found totally --  great minds always think alike  :)
> 
> Mutter.  I have a super-strict (lol) policy of "I don't take patches
> which fix typos/spellos in comments", because we have so many such
> errors, and I'd get buried in silly patches.  But I do take patches
> which fix documentation and user-visible printks, etc.
> 
The first time I know this policy, remember it now ;)

>>  Documentation/hwmon/abituguru-datasheet   |    4 ++--
>>  Documentation/scsi/scsi_fc_transport.txt  |    4 ++--
>>  arch/powerpc/platforms/cell/spufs/spufs.h |    2 +-
>>  drivers/infiniband/hw/nes/nes_cm.c        |    2 +-
>>  drivers/isdn/hardware/eicon/debuglib.h    |    2 +-
>>  drivers/isdn/hardware/eicon/os_4bri.c     |    2 +-
>>  drivers/isdn/hardware/eicon/os_bri.c      |    2 +-
>>  drivers/isdn/hardware/eicon/os_pri.c      |    2 +-
>>  drivers/mtd/ubi/kapi.c                    |    2 +-
>>  drivers/net/wireless/ath5k/dma.c          |    2 +-
>>  drivers/net/wireless/zd1211rw/zd_mac.c    |    2 +-
>>  drivers/s390/block/dasd_3990_erp.c        |    2 +-
>>  drivers/s390/block/dasd_int.h             |    2 +-
>>  drivers/s390/char/tape_3590.c             |    2 +-
>>  drivers/s390/cio/cio.c                    |    2 +-
>>  drivers/s390/cio/qdio_main.c              |    2 +-
>>  fs/ext4/extents.c                         |    2 +-
>>  fs/ocfs2/dlmglue.c                        |    4 ++--
>>  net/sctp/auth.c                           |    2 +-
> 
> This patch sneakily mixed the two up, so I merged it ;)
grep does not understand difference between code and comments ;)
I am not 100% agreed that leaving typos/spellos in comments is a proper policy. Anyway, thanks for
the effort to merge this patch, it's impossible for me to put so many maintainers into Cc list :)

-- 
Coly Li
SuSE PRC Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/