linux-kernel - Re: [patch 05/24] perfmon: X86 generic code (x86)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2008 23:05:29 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	eranian@...glemail.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, mingo@...e.hu, x86@...nel.org,
	eranian@...il.com
Subject: Re: [patch 05/24] perfmon: X86 generic code (x86)

Hi Andi,

On Wed, 26 Nov 2008 12:33:09 +0100 Andi Kleen <andi@...stfloor.org> wrote:
>
> > + * x86 does not need extra alignment requirements for the sampling buffer
> > + */
> > +#define PFM_ARCH_SMPL_ALIGN_SIZE	0
> > +
> > +asmlinkage void  pmu_interrupt(void);
> > +
> > +static inline void pfm_arch_bv_copy(u64 *a, u64 *b, int nbits)
> 
> All these bitmap wrappers just seem like unnecessary obfuscation.
> Could you just drop them and call the standard functions directly?

These were added after comments from the PowerPC maintainer since how the
bitmaps are accessed needs to be arch specific.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped