linux-kernel - Re: Is the change to IDE probing really necessary?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2008 22:48:06 +0100
From:	Bodo Eggert <7eggert@....de>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>, Mel Gorman <mel@....ul.ie>,
	petkovbb@...il.com, sshtylyov@...mvista.com,
	linux-kernel@...r.kernel.org
Subject: Re: Is the change to IDE probing really necessary?

Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> So I think this is a case of 'I put best steam coal in my car and it
> didn't go'

"... but I was told it would."

I think less or different information (resulting in RTFM) might be more
helpful. Looking at the 2.6.27 code, I'd

- change the default to -1 (unset) and let ide_generic_init print the
  text only if it's -1 (and then set it to the default value)
- change the text to
  compiled_in? "please set ide_generic.probe_mask to use the generic IDE driver"
               "please set probe_mask to probe for more legacy interfaces"
- not print anything if all interfaces are probed by default (non-x86)
- document "don't use this driver if there is a more specific driver"
  next to the probe_mask documentation


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/