linux-kernel - Re: [PATCH v2] of_gpio: Return GPIO flags from of_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2008 14:35:54 -0800 (PST)
From:	Trent Piepho <tpiepho@...escale.com>
To:	Paul Mackerras <paulus@...ba.org>
cc:	avorontsov@...mvista.com, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH v2] of_gpio: Return GPIO flags from of_get_gpio()

On Thu, 27 Nov 2008, Paul Mackerras wrote:
> Anton Vorontsov writes:
>
>> Can we apply it? Paul, Benjamin?
>>
>> The patchwork url for this patch is:
>> http://patchwork.ozlabs.org/patch/6650/
>>
>>
>> Thanks!
>>
>>>  drivers/mtd/nand/fsl_upm.c              |    2 +-
>>>  drivers/net/fs_enet/fs_enet-main.c      |    2 +-
>>>  drivers/net/phy/mdio-ofgpio.c           |    4 ++--
>>>  drivers/of/gpio.c                       |   13 ++++++++++---
>>>  drivers/serial/cpm_uart/cpm_uart_core.c |    2 +-
>>>  include/linux/of_gpio.h                 |   21 +++++++++++++++++----
>>>  6 files changed, 32 insertions(+), 12 deletions(-)
>
> That would need acks from Jeff Garzik and David Woodhouse.
>
> Alternatively you could add a new function (called, for instance,
> of_get_gpio_flags) with the extra parameter to eliminate the need to
> change any drivers at this stage, since they all seem to pass NULL for
> the flags argument.

But if we did this every time any exported function needs to change, think
how bloated the API would be with cruft.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/