linux-kernel - Re: [RFC][PATCH -mmotm 0/2] misc patches for memory cgroup hierarchy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Nov 2008 21:49:21 +0900
From:	Daisuke Nishimura <d-nishimura@....biglobe.ne.jp>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	Li Zefan <lizf@...fujitsu.com>,
	Paul Menage <menage@...gle.com>, d-nishimura@....biglobe.ne.jp,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>
Subject: Re: [RFC][PATCH -mmotm 0/2] misc patches for memory cgroup
 hierarchy

On Fri, 28 Nov 2008 19:49:38 +0900
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> wrote:

> On Fri, 28 Nov 2008 18:02:52 +0900
> Daisuke Nishimura <nishimura@....nes.nec.co.jp> wrote:
> 
> > Hi.
> > 
> > I'm writing some patches for memory cgroup hierarchy.
> > 
> > I think KAMEZAWA-san's cgroup-id patches are the most important pathes now,
> > but I post these patches as RFC before going further.
> > 
> Don't wait me ;) I'll rebase mine.
> 
I see :)

> 
> > Patch descriptions:
> > - [1/2] take account of memsw
> >     mem_cgroup_hierarchical_reclaim checks only mem->res now.
> >     It should also check mem->memsw when do_swap_account.
> > - [2/2] avoid oom
> >     In previous implementation, mem_cgroup_try_charge checked the return
> >     value of mem_cgroup_try_to_free_pages, and just retried if some pages
> >     had been reclaimed.
> >     But now, try_charge(and mem_cgroup_hierarchical_reclaim called from it)
> >     only checks whether the usage is less than the limit.
> >     I see oom easily in some tests which didn't cause oom before.
> > 
> > Both patches are for memory-cgroup-hierarchical-reclaim-v4 patch series.
> > 
> > My current plan for memory cgroup hierarchy:
> > - If hierarchy is enabled, limit of child should not exceed that of parent.
>  limit of a child or
>  limit of sum of children ?
> 
I'm sorry for my poor explanation.
I meant *max* of limits of children.

I think setting limit like

	group A (limit=1G)
		group A0 (limit=500M)
		group A1 (limit=800M)

is not wrong itself.


Thanks,
Daisuke Nishimura.

> > - Change other calls for mem_cgroup_try_to_free_page() to
> >   mem_cgroup_hierarchical_reclaim() if possible.
> > 
>  maybe makes sense.
> 
> Thanks,
> -Kame
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/