linux-kernel - [PATCH] pps ldisc: avoid noisy compilation on 64bits architecture.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue,  2 Dec 2008 11:56:07 +0100
From:	Rodolfo Giometti <giometti@...ux.it>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org, Rodolfo Giometti <giometti@...ux.it>
Subject: [PATCH] pps ldisc: avoid noisy compilation on 64bits architecture.

Fix things like these:

drivers/pps/clients/pps-ldisc.c: In function 'pps_tty_dcd_change':
drivers/pps/clients/pps-ldisc.c:32: warning: cast from pointer to integer of different size

Signed-off-by: Rodolfo Giometti <giometti@...ux.it>
---
 drivers/pps/clients/pps-ldisc.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/pps/clients/pps-ldisc.c b/drivers/pps/clients/pps-ldisc.c
index 234867b..f16396b 100644
--- a/drivers/pps/clients/pps-ldisc.c
+++ b/drivers/pps/clients/pps-ldisc.c
@@ -29,7 +29,7 @@
 static void pps_tty_dcd_change(struct tty_struct *tty, unsigned int status,
 				struct timespec *ts)
 {
-	int id = (int) tty->disc_data;
+	long id = (long) tty->disc_data;
 	struct timespec __ts;
 	struct pps_ktime pps_ts;
 
@@ -50,7 +50,7 @@ static void pps_tty_dcd_change(struct tty_struct *tty, unsigned int status,
 			NULL);
 
 	pr_debug("PPS %s at %lu on source #%d\n",
-			status ? "assert" : "clear", jiffies, id);
+			status ? "assert" : "clear", jiffies, (int) id);
 }
 
 static int pps_tty_open(struct tty_struct *tty)
@@ -58,7 +58,7 @@ static int pps_tty_open(struct tty_struct *tty)
 	struct pps_source_info info;
 	struct tty_driver *drv = tty->driver;
 	int index = tty->index + drv->name_base;
-	int ret;
+	long ret;
 
 	info.owner = THIS_MODULE;
 	info.dev = NULL;
@@ -79,21 +79,21 @@ static int pps_tty_open(struct tty_struct *tty)
 	/* Should open N_TTY ldisc too */
 	ret = n_tty_open(tty);
 	if (ret < 0)
-		pps_unregister_source((int) tty->disc_data);
+		pps_unregister_source((long) tty->disc_data);
 
-	pr_info("PPS source #%d \"%s\" added\n", ret, info.path);
+	pr_info("PPS source #%d \"%s\" added\n", (int) ret, info.path);
 
 	return 0;
 }
 
 static void pps_tty_close(struct tty_struct *tty)
 {
-	int id = (int) tty->disc_data;
+	long id = (long) tty->disc_data;
 
 	pps_unregister_source(id);
 	n_tty_close(tty);
 
-	pr_info("PPS source #%d removed\n", id);
+	pr_info("PPS source #%d removed\n", (int) id);
 }
 
 struct tty_ldisc_ops pps_ldisc_ops = {
-- 
1.5.3.8

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/