linux-kernel - Re: Changes to Linux/SCSI target mode infrastructure for v2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Dec 2008 12:43:45 +0900
From:	Tejun Heo <tj@...nel.org>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
CC:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Mike Anderson <andmike@...ux.vnet.ibm.com>,
	Mike Christie <michaelc@...wisc.edu>,
	Christoph Hellwig <hch@....de>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Andrew Morton <akpm@...l.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Hannes Reinecke <hare@...e.de>,
	Boaz Harrosh <bharrosh@...asas.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"Linux-iSCSI.org Target Dev" 
	<linux-iscsi-target-dev@...glegroups.com>
Subject: Re: Changes to Linux/SCSI target mode infrastructure for v2.6.28

Hello, Nicholas.

Nicholas A. Bellinger wrote:
> Ok, I am up and running using the following patch against v2.6.28-rc6
> (along with Tejun's patch).   Comments please..?
> 
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index f5d3b96..77f1fe0 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1505,7 +1507,7 @@ static void scsi_kill_request(struct request *req, struct request_queue *q)
>         struct scsi_target *starget = scsi_target(sdev);
>         struct Scsi_Host *shost = sdev->host;
>  
> -       blkdev_dequeue_request(req);
> +       elv_dequeue_request(req->q, req);

I don't think this really matters.  Either one wouldn't really matter.

>         if (unlikely(cmd == NULL)) {
>                 printk(KERN_CRIT "impossible request in %s.\n",
> @@ -1634,7 +1636,7 @@ static void scsi_request_fn(struct request_queue *q)
>                  * Remove the request from the request list.
>                  */
>                 if (!(blk_queue_tagged(q) && !blk_queue_start_tag(q, req)))
> -                       blkdev_dequeue_request(req);
> +                       elv_dequeue_request(req->q, req);
>                 sdev->device_busy++;
>  
>                 spin_unlock(q->queue_lock);

And this change is incorrect.  Timer should start here.  I don't think
you're seeing the same problem.  I'll reply to the original message.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/