lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 01 Dec 2008 23:49:23 -0800 From: "Nicholas A. Bellinger" <nab@...ux-iscsi.org> To: Mike Anderson <andmike@...ux.vnet.ibm.com> Cc: Tejun Heo <tj@...nel.org>, FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>, Mike Christie <michaelc@...wisc.edu>, Christoph Hellwig <hch@....de>, James Bottomley <James.Bottomley@...senPartnership.com>, Andrew Morton <akpm@...l.org>, Alan Stern <stern@...land.harvard.edu>, Hannes Reinecke <hare@...e.de>, Boaz Harrosh <bharrosh@...asas.com>, Jens Axboe <jens.axboe@...cle.com>, linux-scsi <linux-scsi@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, "Linux-iSCSI.org Target Dev" <linux-iscsi-target-dev@...glegroups.com> Subject: Re: Changes to Linux/SCSI target mode infrastructure for v2.6.28 On Mon, 2008-12-01 at 22:40 -0800, Mike Anderson wrote: > Nicholas A. Bellinger <nab@...ux-iscsi.org> wrote: > > On Tue, 2008-12-02 at 13:18 +0900, Tejun Heo wrote: > > > > > > >>> The other one is a BUG_ON in blk/blk-timeout.c:177 in blk_add_timeout() > > > >>> that happens after a few hundred MB of READ_10 traffic, which also > > > >>> appears to pass through elv_dequeue_request() at some point: > > > >>> > > > >>> http://linux-iscsi.org/builds/user/nab/2.6.28-rc6-oops-2.png > > > >>> http://linux-iscsi.org/builds/user/nab/2.6.28-rc6-oops-4.png > > > > > > Hmmm... this means blk_add_timer() is being called after the request > > > is already completed. > > or is it possible since elv_dequeue_request BUG_ON check of queuelist did > not trigger a request is on the queuelist with a timeout_list not empty. > > It would be interesting for a debug run to change the > "BUG_ON(!list_empty(&req->timeout_list))" in blk_add_timer to print out > the cmd_flags plus req->atomic_flags and also add a > "BUG_ON(!list_empty(&rq->timeout_list))" to elv_insert to ensure a request > is never added to the queuelist with a timeout_list not empty. > Sounds good. I will retest w/o the previous changes to scsi_lib.c for elv_dequeue_request() and see what happens. Thanks for your comments, --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists