linux-kernel - Re: [PATCH] Fix compile error in arch/x86/kernel/syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 04 Dec 2008 11:12:05 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Jody McIntyre <scjody@....com>, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...hat.com
Subject: Re: [PATCH] Fix compile error in arch/x86/kernel/syscall_64.c

Arnd Bergmann wrote:
> On Tuesday 02 December 2008, Jody McIntyre wrote:
>> 1965aae3c98397aad957412413c07e97b1bd4e64 broke compilation on one of my
>> systems:
>>
>>   CC      arch/x86/kernel/syscall_64.o
>> arch/x86/kernel/syscall_64.c:27: error: array index in initializer exceeds array bounds
>> arch/x86/kernel/syscall_64.c:27: error: (near initialization for ‘sys_call_table’)
>> arch/x86/kernel/syscall_64.c:27: warning: excess elements in array initializer
>> arch/x86/kernel/syscall_64.c:27: warning: (near initialization for ‘sys_call_table’)
>> make[1]: *** [arch/x86/kernel/syscall_64.o] Error 1
>> make: *** [arch/x86/kernel/syscall_64.o] Error 2
>>
>> Reverting only the parts of the commit that change ASM_X86__UNISTD_64_H
>> to _ASM_X86_UNISTD_64_H fixes the problem.  Patch below.
>>
>> I have no idea what's going on here.  Compiler bug?
> 
> Maybe you have stale header files in include/asm-x86/? That sometimes
> happens if you git-checkout -f or git-reset --hard.
> 

"git cleanup" should be used to catch that classes of problems.  I did
notice that the include file trace used include/asm not
arch/x86/include/asm, which to me implies something like this.

I just tried, and when I make a .i file on a clean tree I get:

# 10 "<full path>/arch/x86/include/asm/posix_types_64.h"

not

# 10 "include/asm/posix_types_64.h"

as the posted .i file has.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/