lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 6 Dec 2008 14:20:47 +0600
From:	"Rakib Mullick" <rakib.mullick@...il.com>
To:	"Linux-kernel Mailing List" <linux-kernel@...r.kernel.org>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: [PATCH] kernel/freezer.c : Removing extra checking.

Impact: Reduces an extra checking.

Following patch removes an extra checking. We can remove it since, the
current task is frozen. If the current task is not frozen, then it
will return from __else__ condition of freezing(current) check. So,
the check becames unnecessary. It also reduces 32 bytes of text space
on my x86  (32 bit) system.

Signed-off-by: Rakib Mullick <rakib.mullick@...il.com>

--- linux-2.6-orig/kernel/freezer.c	2008-12-05 19:53:45.000000000 +0600
+++ linux-2.6/kernel/freezer.c	2008-12-05 19:55:40.000000000 +0600
@@ -46,8 +46,6 @@ void refrigerator(void)

 	for (;;) {
 		set_current_state(TASK_UNINTERRUPTIBLE);
-		if (!frozen(current))
-			break;
 		schedule();
 	}
 	pr_debug("%s left refrigerator\n", current->comm);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ