linux-kernel - Re: [patch] ohci1394: don't leave interrupts enabled during suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Dec 2008 21:28:17 -0600
From:	Robert Hancock <hancockr@...w.ca>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	Frans Pop <elendil@...net.nl>, "Rafael J. Wysocki" <rjw@...k.pl>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [patch] ohci1394: don't leave interrupts enabled during suspend/resume

Stefan Richter wrote:
> Robert Hancock wrote:
>> If free_irq and 
>> request_irq fix anything, then that indicates that the ohci1394 device 
>> is generating interrupts at some point during resume,
> ...
>> Likely the driver should be setting some register on the device to 
>> disable it from generating interrupts before suspend and it's not doing 
>> this.
> 
> 	reg_write(ohci, OHCI1394_IntMaskClear, 0xffffffff);
> 
> in ohci1394's .suspend() switches interrupts off.

Presumably it should.. but the fact remains that if free_irq helps 
anything, then the device must be generating interrupts for some reason, 
and it's really just papering over the problem. Perhaps a quirk of that 
particular chip? Something to do with the state it's in after resume?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/