linux-kernel - Re: [Patch] uml: drop const qualifier for kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 7 Dec 2008 20:55:38 +0100
From:	Johannes Weiner <hannes@...xchg.org>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>, jdike@...toit.com,
	user-mode-linux-devel@...ts.sourceforge.net
Subject: Re: [Patch] uml: drop const qualifier for kernel_execve()

On Sat, Dec 06, 2008 at 01:02:16AM +0000, Américo Wang wrote:
> On Wed, Dec 3, 2008 at 1:40 PM, Johannes Weiner <hannes@...xchg.org> wrote:
> > On Wed, Dec 03, 2008 at 12:32:02PM +0000, Américo Wang wrote:
> >> On Wed, Dec 3, 2008 at 1:20 AM, Johannes Weiner <hannes@...xchg.org> wrote:
> >> > On Tue, Dec 02, 2008 at 10:51:09PM +0000, Américo Wang wrote:
> >> >> UML implementation of kernel_execve() should not have const qualifier,
> >> >> because it will finally call do_execve() which doesn't have.
> >> >
> >> > And you made sure that do_execve() is correctly annotated?
> >> >
> >>
> >> Yes, I checked that.
> >
> > Good.  Then please fix up do_execve() or let the warning stand out as
> > a reminder.
> 
> ??
> Confused...
> 
> do_execve() is OK, we don't need to fix it.

I don't see where it writes through @filename.  So it seems the right
fix would be to make do_execve()s parameter const (and as it seems, a
lot more adjustments down this call graph) and not remove a correct
const from a callsite.

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/