lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Dec 2008 10:58:50 +0900 (JST) From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> To: "Luck, Tony" <tony.luck@...el.com>, Rusty Russell <rusty@...tcorp.com.au> Cc: kosaki.motohiro@...fujitsu.com, linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Stephen Rothwell <sfr@...b.auug.org.au> Subject: [linux-next][PATCH] cpumask:cpumask_of_node-ia64 fix === Subject: [PATCH] cpumask:cpumask_of_node-ia64 fix Impact: bug fix commit 07c636deede53ff3e96d54df0ece2c838e61951f introduce new CPU mask API and change cpu_mask variable type. ----------------------------------------------- - cpumask_t cpu_mask; + const struct cpumask *cpu_mask; -------------------------------------------------- However, its change is incomplete. in build time, compiler output following type mismatch warnings. arch/ia64/kernel/iosapic.c:708: warning: passing argument 2 of '__cpu_clear' from incompatible pointer type arch/ia64/kernel/iosapic.c:711: warning: passing argument 1 of '__cpus_weight' from incompatible pointer type arch/ia64/kernel/iosapic.c:719: warning: passing argument 1 of '__first_cpu' from incompatible pointer type arch/ia64/kernel/iosapic.c:720: warning: passing argument 2 of '__next_cpu' from incompatible pointer type Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> CC: "Luck, Tony" <tony.luck@...el.com> CC: Rusty Russell <rusty@...tcorp.com.au> --- arch/ia64/kernel/iosapic.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) Index: b/arch/ia64/kernel/iosapic.c =================================================================== --- a/arch/ia64/kernel/iosapic.c +++ b/arch/ia64/kernel/iosapic.c @@ -695,7 +695,7 @@ get_target_cpu (unsigned int gsi, int ir #ifdef CONFIG_NUMA { int num_cpus, cpu_index, iosapic_index, numa_cpu, i = 0; - const struct cpumask *cpu_mask; + struct cpumask *cpu_mask; iosapic_index = find_iosapic(gsi); if (iosapic_index < 0 || @@ -705,10 +705,10 @@ get_target_cpu (unsigned int gsi, int ir cpu_mask = cpumask_of_node(iosapic_lists[iosapic_index].node); for_each_cpu_and(numa_cpu, cpu_mask, &domain) { if (!cpu_online(numa_cpu)) - cpu_clear(numa_cpu, cpu_mask); + cpu_clear(numa_cpu, *cpu_mask); } - num_cpus = cpus_weight(cpu_mask); + num_cpus = cpus_weight(*cpu_mask); if (!num_cpus) goto skip_numa_setup; @@ -716,8 +716,8 @@ get_target_cpu (unsigned int gsi, int ir /* Use irq assignment to distribute across cpus in node */ cpu_index = irq % num_cpus; - for (numa_cpu = first_cpu(cpu_mask) ; i < cpu_index ; i++) - numa_cpu = next_cpu(numa_cpu, cpu_mask); + for (numa_cpu = first_cpu(*cpu_mask) ; i < cpu_index ; i++) + numa_cpu = next_cpu(numa_cpu, *cpu_mask); if (numa_cpu != NR_CPUS) return cpu_physical_id(numa_cpu); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists