lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 11 Dec 2008 13:02:06 +0800 From: Jianjun Kong <jianjun@...ux.org> To: Nguyen Anh Quynh <aquynh@...il.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Al Viro <viro@...iv.linux.org.uk>, LKML <linux-kernel@...r.kernel.org>, Kuniyasu Suzaki <k.suzaki@...t.go.jp> Subject: Re: [PATCH] fix calls to request_module() * Nguyen Anh Quynh wrote: >On Thu, Dec 11, 2008 at 1:40 PM, Jianjun Kong <jianjun@...ux.org> wrote: >> * Nguyen Anh Quynh wrote: >>>>> > The request_module() function should always have the 1st param as a >>>>> > format argument. So for example, request_module("i2c-powermac") should >>>>> > be called as request_module("%s", "i2c-powermac"). Otherwise, new gcc >>>>> > like gcc 4.3.2 on Ubuntu 8.10 would spit out a lot of warnings. This >>>>> > patch fixes them all in linus-git tree. <sign> >> Hi,all >> I also use Ubuntu 8.10, gcc version 4.3.2 (Ubuntu 4.3.2-1ubuntu11) >> >> When I compile the latest kernel, there are more warning. Like this: <sign> >> arch/x86/kernel/e820.c: In function 'early_panic': >> arch/x86/kernel/e820.c:1172: warning: format not a string literal and no format arguments >> arch/x86/kernel/e820.c:1173: warning: format not a string literal and no format arguments >> kernel/power/main.c: In function 'test_suspend': >> kernel/power/main.c:720: warning: format not a string literal and no format arguments >> fs/dquot.c: In function 'find_quota_format': >> fs/dquot.c:170: warning: format not a string literal and no format arguments >> crypto/api.c: In function 'crypto_larval_lookup': >> crypto/api.c:218: warning: format not a string literal and no format arguments >> crypto/algapi.c: In function 'crypto_lookup_template': >> crypto/algapi.c:427: warning: format not a string literal and no format arguments >> ... > >I saw the same thing. My patch only fixed part of them. > >So please submit your patch to fix the remainig :-) But there is no this kind of warns at Fedora 10, gcc version 4.3.2 20081105 (Red Hat 4.3.2-7) We should make clean whether your patch is correct first. There are many more that kind of warns. I just list little of them. Jianjun -- Jianjun Kong |Happy Hacking Homepage: http://kongove.cn Gtalk:KongJianjun@...il.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists