linux-kernel - RE: [PATCH] x86, bts: fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Dec 2008 08:46:46 +0000
From:	"Metzger, Markus T" <markus.t.metzger@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	"hpa@...or.com" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"markus.t.metzger@...il.com" <markus.t.metzger@...il.com>,
	"roland@...hat.com" <roland@...hat.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"eranian@...glemail.com" <eranian@...glemail.com>
Subject: RE: [PATCH] x86, bts: fix build error

>-----Original Message-----
>From: Ingo Molnar [mailto:mingo@...e.hu] 
>Sent: Freitag, 12. Dezember 2008 08:23
>To: Metzger, Markus T

>i fixed a build failure via the commit below - but the 
>recursion in that 
>code is really nasty. Could you please clean it all up to plain flat 
>code?

Sure.

How could I find those things myself?
Gcc 4.3.0 does not even give a warning for a defconfig build. Is there a config option I should set?


thanks,
markus.


>
>	Ingo
>
>----------------->
>>From ffc2238af8431d930d2c15f16feecf1fd6d75642 Mon Sep 17 00:00:00 2001
>From: Ingo Molnar <mingo@...e.hu>
>Date: Fri, 12 Dec 2008 08:21:19 +0100
>Subject: [PATCH] x86, bts: fix build error
>
>Impact: build fix
>
> arch/x86/kernel/ds.c: In function 'ds_request':
> arch/x86/kernel/ds.c:236: sorry, unimplemented: inlining 
>failed in call to 'ds_get_context': recursive inlining
>
>but the recursion here is scary ...
>
>Signed-off-by: Ingo Molnar <mingo@...e.hu>
>---
> arch/x86/kernel/ds.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/arch/x86/kernel/ds.c b/arch/x86/kernel/ds.c
>index f058300..dc1e712 100644
>--- a/arch/x86/kernel/ds.c
>+++ b/arch/x86/kernel/ds.c
>@@ -232,7 +232,7 @@ static DEFINE_PER_CPU(struct ds_context *, 
>system_context_array);
> 
> #define system_context per_cpu(system_context_array, 
>smp_processor_id())
> 
>-static inline struct ds_context *ds_get_context(struct 
>task_struct *task)
>+static struct ds_context *ds_get_context(struct task_struct *task)
> {
> 	struct ds_context **p_context =
> 		(task ? &task->thread.ds_ctx : &system_context);
>
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/