lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Jul 2007 11:24:51 +1000 From: Nick Piggin <nickpiggin@...oo.com.au> To: Eric Dumazet <dada1@...mosbay.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Ingo Molnar <mingo@...e.hu>, Christoph Hellwig <hch@...radead.org>, David Miller <davem@...emloft.net>, "Rafael J. Wysocki" <rjw@...k.pl>, linux-kernel@...r.kernel.org, "kernel-testers@...r.kernel.org >> Kernel Testers List" <kernel-testers@...r.kernel.org>, Mike Galbraith <efault@....de>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Linux Netdev List <netdev@...r.kernel.org>, Christoph Lameter <cl@...ux-foundation.org>, linux-fsdevel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> Subject: Re: [PATCH v3 1/7] fs: Use a percpu_counter to track nr_dentry On Friday 12 December 2008 09:38, Eric Dumazet wrote: > Adding a percpu_counter nr_dentry avoids cache line ping pongs > between cpus to maintain this metric, and dcache_lock is > no more needed to protect dentry_stat.nr_dentry > > We centralize nr_dentry updates at the right place : > - increments in d_alloc() > - decrements in d_free() > > d_alloc() can avoid taking dcache_lock if parent is NULL > > ("socketallocbench -n8" result : 27.5s to 25s) Seems like a good idea. > @@ -696,7 +712,7 @@ static void shrink_dcache_for_umount_subtree(struct > dentry *dentry) * otherwise we ascend to the parent and move to the > * next sibling if there is one */ > if (!parent) > - goto out; > + return; > > dentry = parent; > Andrew doesn't like return from middle of function. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists