linux-kernel - [RFC][PATCH] Give up reclaim quickly when fatal signal received.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 12 Dec 2008 21:21:11 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>
Cc:	kosaki.motohiro@...fujitsu.com
Subject: [RFC][PATCH] Give up reclaim quickly when fatal signal received.

I don't mesure any performance yet.
This is purely discussion purpose patch.

==
Subject: [RFC][PATCH] Give up reclaim quickly when fatal signal received.

In some hosting service and data center and HPC server, process watching
daemon watch to exist bad boy process periodically. and if exist, the watcher
send SIGKILL to bad boy. 
It assume to dead SIGKILLed process immediately.

In the other hand, reclaim is generally very slow processing.
if process is reclaiming, the process is not dead long time although process
die can make much free memory than reclaim.

But, there is one big risk. there are low quality and poor error handling
driver in the world. alloc_page(GFP_KERNEL) failure can expose these 
poor driver mistake and panic kernel.

Luckily, any driver don't use __GFP_RECLAIMABLE and __GFP_MOVABLE. these flags 
indicate caller need for userland memory.
Therefore we can assume this flag mean alloc_pages() failure safe.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
---
 mm/page_alloc.c |    3 +++
 mm/vmscan.c     |   11 +++++++++++
 2 files changed, 14 insertions(+)

Index: b/mm/page_alloc.c
===================================================================
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1536,6 +1536,9 @@ restart:
 	/* This allocation should allow future memory freeing. */

 rebalance:
+	if ((gfp_mask & GFP_MOVABLE_MASK) && fatal_signal_pending(current))
+		goto nopage;
+
 	if (((p->flags & PF_MEMALLOC) || unlikely(test_thread_flag(TIF_MEMDIE)))
 			&& !in_interrupt()) {
 		if (!(gfp_mask & __GFP_NOMEMALLOC)) {
Index: b/mm/vmscan.c
===================================================================
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1514,6 +1514,11 @@ static void shrink_zones(int priority, s
 	for_each_zone_zonelist(zone, z, zonelist, high_zoneidx) {
 		if (!populated_zone(zone))
 			continue;
+
+		if ((sc->gfp_mask & GFP_MOVABLE_MASK) &&
+		    fatal_signal_pending(current))
+			break;
+
 		/*
 		 * Take care memory controller reclaiming has small influence
 		 * to global LRU.
@@ -1610,6 +1615,12 @@ static unsigned long do_try_to_free_page
 			ret = sc->nr_reclaimed;
 			goto out;
 		}
+		if ((sc->gfp_mask & GFP_MOVABLE_MASK) &&
+		    fatal_signal_pending(current)) {
+			/* if ret = 0, caller invoke oom killer. */
+			ret = 1;
+			goto out;
+		}

 		/*
 		 * Try to write back as many pages as we just scanned.  This

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/