linux-kernel - Re: [PATCH] nohz: no softirq pending warnings for offline cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 12 Dec 2008 07:27:23 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	linux-kernel@...r.kernel.org,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [PATCH] nohz: no softirq pending warnings for offline cpus


* Heiko Carstens <heiko.carstens@...ibm.com> wrote:

> From: Heiko Carstens <heiko.carstens@...ibm.com>
> 
> After a cpu was taken down during cpu hotplug (read: disabled for interrupts)
> it still might have pending softirqs. However take_cpu_down makes sure
> that the idle task will run next instead of ksoftirqd on the taken down cpu.
> The idle task will call tick_nohz_stop_sched_tick which might warn about
> pending softirqs just before the cpu kills itself completely.
> However the pending softirqs on the dead cpu aren't a problem because they
> will be moved to an online cpu during CPU_DEAD handling.
> 
> So make sure we warn only for online cpus.
> 
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
>  kernel/time/tick-sched.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to tip/timers/nohz, thanks Heiko!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/