linux-kernel - Re: [PATCH 3/4] ieee1394: mark bus_info_data was a _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Dec 2008 16:53:11 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/4] ieee1394: mark bus_info_data was a __be32 array

On Sun, 2008-12-14 at 01:38 +0100, Stefan Richter wrote:
> Harvey Harrison wrote:
> > Two access functions get_max_rom and set_hw_config_rom are
> > changed to take __be32 as well.  Only bus_info_data was
> > ever passed in so this is OK.  All other uses of bus_info_data
> > treated it as a be32 value already.
> 
> I pushed the following out to linux1394-2.6.git:
> 
> Harvey Harrison (6):
>       ieee1394: pcilynx: trivial endian annotation
>       ieee1394: replace CSR_SET_BUS_INFO_GENERATION macro
>       ieee1394: mark bus_info_data as a __be32 array
>       ieee1394: eth1394: trivial sparse annotations
>       ieee1394: dv1394 annotate frame input/output structs as little endian
>       ieee1934: dv1394: interrupt enabling/disabling broken on big-endian
> 
> Note, I dropped two hunks from "mark bus_info_data..." due to another
> change which I posted only a few hours ago.  Please check:
> http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commitdiff;h=d88b81b772c6db76eb3b9f9564034f55d0dcdd09
> This interfered with your patch:
> http://git.kernel.org/?p=linux/kernel/git/ieee1394/linux1394-2.6.git;a=commitdiff;h=6b09b72cbdcba8da71b85651eb37e0156aa65def
> 
> I pulled your patches into my master branch but not yet into my for-next
> branch (awaiting possible feedback on what I enqueued before your patches).

Looks OK to me, I needed to change the definition of get_max_rom to take
a be32 as it was only ever passed the bus_info_data, now that the other
patch removes that function entirely, the two hunks you dropped are no
longer needed.

Cheers,

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/