linux-kernel - Re: time_is_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Dec 2008 17:32:43 +0100 (MET)
From:	"Peter T. Breuer" <ptb@....it.uc3m.es>
To:	"Andreas Schwab" <schwab@...e.de>
CC:	"linux kernel" <linux-kernel@...r.kernel.org>
Subject: Re: time_is_after_jiffies misnomer

"Also sprach Andreas Schwab:"
[Charset iso-8859-1 unsupported, filtering to ASCII...]
> "Peter T. Breuer" <ptb@....it.uc3m.es> writes:
> 
> > Look at the two:
> >
> >    the current time is later than foo jiffies
> >                  |   |  |           `/.
> >                time_is_after_jiffies(foo)
> 
> It's not "foo jiffies", it's time "foo" vs time "jiffies" (where jiffies
> is the well known global variable).

Forgive me, but you don't seem to really be taking it on board here
either ...  what it SAYS to an english reader is the opposite of what
you intend it to MEAN, unfortunately :(.

So the name is wrong. It's simple to fix. Just change the name. The
simplest naming fix is from

    time_is_after_jiffies(foo)

to

    time_is_before_jiffies(foo)

but obviously that would create more confusion yet, given the
unfortunate current scheme!  So how about keeping the current macro
names but gradually phasing them out in favour of a parallel set of 
alternatives, which could be

    current_time_is_before_jiffies(foo)

?? That reads fine in english and this time it means what it says!

Best regards

Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/