lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Dec 2008 01:45:07 +0100 From: Hans Verkuil <hverkuil@...all.nl> To: v4l-dvb-maintainer@...uxtv.org Cc: Randy Dunlap <randy.dunlap@...cle.com>, linux-kernel@...r.kernel.org, video4linux-list@...hat.com, Andrew Morton <akpm@...ux-foundation.org>, Mauro Carvalho Chehab <mchehab@...radead.org> Subject: Re: [v4l-dvb-maintainer] [PATCH -next/mmotm] media/video/tuner: fix tuner_ioctl build error On Saturday 20 December 2008 01:36:48 Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@...cle.com> > > Fix drivers/media/video/tuner-core.c so that it will build when > CONFIG_VIDEO_ALLOW_V4L1=n: > > drivers/media/video/tuner-core.c:1111: error: 'tuner_ioctl' undeclared > here (not in a function) > > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com> > cc: Mauro Carvalho Chehab <mchehab@...radead.org> > cc: v4l-dvb-maintainer@...uxtv.org > cc: video4linux-list@...hat.com > --- > drivers/media/video/tuner-core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > --- mmotm-2008-1219-1438.orig/drivers/media/video/tuner-core.c > +++ mmotm-2008-1219-1438/drivers/media/video/tuner-core.c > @@ -919,6 +919,11 @@ static int tuner_ioctl(struct v4l2_subde > } > return -ENOIOCTLCMD; > } > +#else > +static int tuner_ioctl(struct v4l2_subdev *sd, int cmd, void *arg) > +{ > + return -ENOIOCTLCMD; > +} > #endif > > static int tuner_s_config(struct v4l2_subdev *sd, const struct > v4l2_priv_tun_config *cfg) NAK. I've already made a better fix for this and asked Mauro to pull this from my tree. The tuner_ioctl function pointer should have been under the CONFIG_VIDEO_ALLOW_V4L1 #ifdef as well avoiding the need to make an empty function. Nevertheless, thanks for the effort! Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists