linux-kernel - Re: [irda-users] [PATCH] OMAP IrDA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Dec 2008 16:50:25 +0530
From:	"Trilok Soni" <soni.trilok@...il.com>
To:	"Tony Lindgren" <tony@...mide.com>
Cc:	samuel@...tiz.org, linux-kernel@...r.kernel.org,
	irda-users@...ts.sourceforge.net,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-omap@...r.kernel.org
Subject: Re: [irda-users] [PATCH] OMAP IrDA driver

Hi Tony,

>
>> +
>> +/*
>> + * Set the IrDA communications speed.
>> + * Interrupt have to be disabled here.
>> + */
>> +static int omap_irda_startup(struct net_device *dev)
>> +{
>> +     struct omap_irda *omap_ir = netdev_priv(dev);
>> +
>> +     /* FIXME: use clk_* apis for UART3 clock*/
>> +     /* Enable UART3 clock and set UART3 to IrDA mode */
>> +     if (machine_is_omap_h2() || machine_is_omap_h3())
>> +             omap_writel(omap_readl(MOD_CONF_CTRL_0) | (1 << 31) | (1 << 15),
>> +                             MOD_CONF_CTRL_0);

This looks like muxing on H3.

>> +
>> +     /* Only for H2?
>> +      */
>> +     if (omap_ir->pdata->transceiver_mode && machine_is_omap_h2()) {
>> +             /* Is it select_irda on H2 ? */
>> +             omap_writel(omap_readl(FUNC_MUX_CTRL_A) | 7,
>> +                                     FUNC_MUX_CTRL_A);
>> +             omap_ir->pdata->transceiver_mode(omap_ir->dev, IR_SIRMODE);
>> +     }
>> +
>

I can move this to board-h3.c file instead with platform data flag probably.


-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/