lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Dec 2008 15:58:37 -0800 From: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com> To: Oleg Nesterov <oleg@...hat.com> Cc: ebiederm@...ssion.com, roland@...hat.com, bastian@...di.eu.org, daniel@...ac.com, xemul@...nvz.org, containers@...ts.osdl.org, linux-kernel@...r.kernel.org, sukadev@...ibm.com Subject: Re: [RFC][PATCH 4/6][v3] Define siginfo_from_ancestor_ns() Oleg Nesterov [oleg@...hat.com] wrote: | On 12/22, Oleg Nesterov wrote: | > | > On 12/20, Sukadev Bhattiprolu wrote: | > > | > > + * TODO: | > > + * Making SI_ASYNCIO a kernel signal could make this less hacky. | > > + */ | > > +#ifdef CONFIG_PID_NS | > > +static inline int siginfo_from_user(siginfo_t *info) | > > +{ | > > + if (!is_si_special(info) && SI_FROMUSER(info) && | > | > OK, if we can trust SI_FROMUSER(), then it is better, i agree. | | Aaah, forgot to mention... | | But could you explain how are you going to fix another problem, | .si_pid mangling? This was another reason for (yes, ugly, agreed) | SIG_FROM_USER in .si_signo. Good point. I was going through the ->si_pid assignments to try and fix them at source (like the mqueue patch I sent last week). The two cases that don't fit the model are sys_kill() and sys_tkill(). For that I was hoping we could use siginfo_from_user() again. i.e if (siginfo_from_user()) masquerade_si_pid() in the default: case of send_signal(). To be safe, masquerade_si_pid() could do it only iff si_code is either SI_USER or SI_TKILL. IOW, with some tweaks, I am trying to see if we can use siginfo_from_user() in place of the SIG_FROM_USER. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists