linux-kernel - Re: [PATCH] USB: Driver for Freescale QUICC Engine USB Host Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Dec 2008 22:11:43 +0300
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <greg@...ah.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Timur Tabi <timur@...escale.com>,
	Li Yang <leoli@...escale.com>, linux-usb@...r.kernel.org,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: Driver for Freescale QUICC Engine USB Host
	Controller

On Tue, Dec 23, 2008 at 09:45:09PM -0500, Alan Stern wrote:
> On Wed, 24 Dec 2008, Anton Vorontsov wrote:
> 
> > This patch adds support for the FHCI USB controller, as found
> > in the Freescale MPC836x and MPC832x processors. It can support
> > Full or Low speed modes.
> > 
> > Quite a lot the hardware is doing by itself (SOF generation, CRC
> > generation and checking), though scheduling and retransmission is on
> > software's shoulders.
> > 
> > This controller does not integrate the root hub, so this driver also
> > fakes one-port hub. External hub is required to support more than
> > one device.
> 
> It looks like the kernel this was written for is several versions out 
> of date.

Yeah, originally it was written for 2.6.10. Though the driver I
posted is for the linux-next, and it works quite well w/o the
{un,}link_urb calls. ;-)

> The driver is missing some critical calls to functions like 
> usb_hcd_link_urb_to_ep().

Fixed.

Thanks for review!

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/