linux-kernel - Re: [PATCH] smackfs: check for allocation failures in smk_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Dec 2008 12:17:01 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Casey Schaufler <casey@...aufler-ca.com>
cc:	Sergio Luis <sergio@...ces.uece.br>,
	"Ahmed S. Darwish" <darwish.07@...il.com>,
	LSM <linux-security-module@...r.kernel.org>,
	LKLM <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] smackfs: check for allocation failures in
 smk_set_access()

On Mon, 22 Dec 2008, Casey Schaufler wrote:

> Sergio Luis wrote:
> >  smackfs: check for allocation failures in smk_set_access() 
> >  While adding a new subject/object pair to smack_list, smk_set_access()
> >  didn't check the return of kzalloc(). 
> >  This patch changes smk_set_access() to return 0 or -ENOMEM, based on
> > kzalloc()'s return. It also updates its caller, smk_write_load(), to
> >  check for smk_set_access()'s return, given it is no longer a void  return
> > function.
> > 
> >  Signed-off-by: Sergio Luis <sergio@...ces.uece.br>
> >  To: Casey Schaufler <casey@...aufler-ca.com>
> >  Cc: Ahmed S. Darwish <darwish.07@...il.com>
> >  Cc: LSM <linux-security-module@...r.kernel.org>
> >  Cc: LKLM <linux-kernel@...r.kernel.org>
> >   
> 
> Acked-by: Casey Schaufler <casey@...aufler-ca.com>
> 

Applied to:
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

I'll push this to Linus after he pulls the main security update, or with 
it on re-send.

-- 
-- 
James Morris
<jmorris@...ei.org>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/