linux-kernel - Re: [RFC PATCH -v4 00/14] fsnotify, dnotify, and inotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Dec 2008 13:17:28 -0500
From:	"C. Scott Ananian" <cscott@...top.org>
To:	"Christoph Hellwig" <hch@...radead.org>
Cc:	"Al Viro" <viro@...iv.linux.org.uk>,
	"Eric Paris" <eparis@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH -v4 00/14] fsnotify, dnotify, and inotify

On Mon, Dec 22, 2008 at 6:21 PM, Christoph Hellwig <hch@...radead.org> wrote:
> On Mon, Dec 22, 2008 at 06:08:08PM -0500, C. Scott Ananian wrote:
>> That's not correct, as /proc/self/fd/<num> and the getcwd syscall make
>> clear.
>
> No.  These take a file descriptor into account, which _does_ have a
> unique path.

getcwd doesn't actually hold a file descriptor to the working
directory.  If you reread my message, you'll find that I was explicit
about where the information was stored.

>> struct inode has a i_dentry member, and via its d_parent links
>> you can reconstruct the path, as __d_path in fs/dcache.c does.
>
> reconstruct _a_ path inside the same filesystem, ignoring which link is
> wanted, and inside which mount.

Right.  If you go back and reread my message, I made clear that that
was sufficient.

But Al's question is more relevant, and I'll try to restate the
problem for him, since it's clear that none of the existing *notify
interfaces was written with an eye towards making possible races
easily manageable.
  --scott

-- 
                         ( http://cscott.net/ )
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/