lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Dec 2008 16:00:56 +0900 From: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp> To: xiyou.wangcong@...il.com Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org Subject: Re: [PATCH] Check return from argv_split() in do_coredump(). Hello. Am.$(D+1rico Wang wrote: > How about going to the line: > > current->fsuid = fsuid; > > ? Because when argv_split() fails, helper_argv is NULL and doesn't need > to be checked again. I didn't understand what you say. I'm saying that "do_coredump() may accesss helper_argv[0] when helper_argv == NULL", which will result in "NULL pointer dereference" problem. Yes, this problem unlikely happens. Thus, if (!helper_argv) goto fail_unlock; may be enough. Regards. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists