linux-kernel - Re: [RFC] boot parameter handling cleanup II

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 27 Dec 2008 11:14:26 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Rusty Russell <rusty@...tcorp.com.au>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	Yinghai Lu <yinghai@...nel.org>, Hugh Dickins <hugh@...itas.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, "Luck, Tony" <tony.luck@...el.com>
Subject: Re: [RFC] boot parameter handling cleanup II


* Rusty Russell <rusty@...tcorp.com.au> wrote:

> (Not much change since last time, just consolidated fixes aired here, esp.
>  x86 early_param fixes thanks to Hugh and Yinghai.)
> 
> The following changes since commit 4a6908a3a050aacc9c3a2f36b276b46c0629ad91:    
>   Linus Torvalds (1):                                                           
>         Linux 2.6.28                                                            
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-boot-params.git master                                                                          

(it would be useful to embedd the full patch in such cases in the email - 
makes for a quicker review)

>  arch/x86/include/asm/cpufeature.h          |    4 +-
>  arch/x86/include/asm/processor.h           |    3 +-
>  arch/x86/kernel/cpu/common.c               |   22 +++++--
>  arch/x86/kernel/e820.c                     |   88 +++++++++++++++++----------
>  arch/x86/kernel/setup.c                    |   41 ++++++-------
>  arch/x86/mm/init_32.c                      |   11 ++-

no objections from the x86 perspective, as long as it does not break 
stuff. If it breaks stuff it's all your fault ;-) I checked these commits:

 218a372: x86: override_capabilities in early_identify_cpu
 5144b68: x86: prepare noexec for being called earlier
 5689919: x86: clean up setup_clear/force_cpu_cap handling
 b41144e: x86: act on mem= and memmap= later in boot

and they definitely look like a step forward.

One detail: please send a pull request to Linus after the pending x86 tree 
went upstream, so that there are no conflicts with existing x86 items. 
There will be a (trivial) context-overlap conflict in 
arch/x86/kernel/cpu/common.c.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/