linux-kernel - Re: [PATCH 0 of 9] swiotlb: use phys_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 27 Dec 2008 11:48:23 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Tony Luck <tony.luck@...el.com>
Cc:	linux-kernel@...r.kernel.org,
	Xen-devel <xen-devel@...ts.xensource.com>,
	the arch/x86 maintainers <x86@...nel.org>,
	Ian Campbell <ian.campbell@...rix.com>,
	Becky Bruce <beckyb@...nel.crashing.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Subject: Re: [PATCH 0 of 9] swiotlb: use phys_addr_t for pages


* Jeremy Fitzhardinge <jeremy@...p.org> wrote:

> Hi all,
> 
> Here's a work in progress series whcih does a partial revert of the 
> previous swiotlb changes, and does a partial replacement with Becky 
> Bruce's series.
> 
> The most important difference is Becky's use of phys_addr_t rather than 
> page+offset to represent arbitrary pages.  This turns out to be simpler.
> 
> I didn't replicate the map_single_page changes, since I'm not exactly 
> sure of ppc's requirements here, and it seemed like something that could 
> be easily added.
> 
> Quick testing showed no problems, but I haven't had the chance to do 
> anything extensive.
> 
> I've made some small changes to Becky's patches to make them apply, but 
> I've separated any functional changes into separate patches with 
> appropriate authorship.

looks good to me in principle. Fujita-san, do you have any principal 
objections against these generalizations?

Also, this patch will interact with ia64 materially:

  Subject: [PATCH 9 of 9] ia64/x86/swiotlb: use enum dma_data_direciton in dma_ops

So we'll need a bit more confidence in the testing status of this queue, 
and we probably want to wait until Tony merged the pending .29 ia64 
changes, and also get an Ack from Tony for these bits:

 arch/ia64/dig/dig_vtd_iommu.c       |    9 +++--
 arch/ia64/hp/common/hwsw_iommu.c    |   22 ++++++++------
 arch/ia64/hp/common/sba_iommu.c     |   12 ++++---
 arch/ia64/include/asm/dma-mapping.h |   29 +++++++++---------
 arch/ia64/include/asm/swiotlb.h     |   26 ++++++++++------
 arch/ia64/kernel/machvec.c          |    6 ++-
 arch/ia64/sn/kernel/io_common.c     |    3 +-
 arch/ia64/sn/pci/pci_dma.c          |   21 ++++++++-----
 arch/ia64/sn/pci/pcibr/pcibr_dma.c  |    3 +-
 arch/ia64/sn/pci/tioca_provider.c   |    3 +-

(Tony Cc:-ed)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/