linux-kernel - Re: linux-next: Tree for December 29 (fcoe)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Dec 2008 14:21:45 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	James Bottomley <James.Bottomley@...senpartnership.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	scsi <linux-scsi@...r.kernel.org>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Tree for December 29 (fcoe)

James Bottomley wrote:
> 
> Actually, I deduce the problem is owner->name and your build has
> CONFIG_MODULE=n ... the definition of struct module is enclosed in a
> #ifdef CONFIG_MODULE.
> 
> This should fix it.
> 
> James

Ack.  Thanks.

> ---
> 
> diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c
> index 1cb549c..fec38f6 100644
> --- a/drivers/scsi/fcoe/libfcoe.c
> +++ b/drivers/scsi/fcoe/libfcoe.c
> @@ -992,7 +992,7 @@ static int fcoe_ethdrv_get(const struct net_device *netdev)
>  	owner = fcoe_netdev_to_module_owner(netdev);
>  	if (owner) {
>  		printk(KERN_DEBUG "foce:hold driver module %s for %s\n",
> -		       owner->name, netdev->name);
> +		       module_name(owner), netdev->name);
>  		return  try_module_get(owner);
>  	}
>  	return -ENODEV;
> @@ -1012,7 +1012,7 @@ static int fcoe_ethdrv_put(const struct net_device *netdev)
>  	owner = fcoe_netdev_to_module_owner(netdev);
>  	if (owner) {
>  		printk(KERN_DEBUG "foce:release driver module %s for %s\n",
> -		       owner->name, netdev->name);
> +		       module_name(owner), netdev->name);
>  		module_put(owner);
>  		return 0;
>  	}
> 
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/