linux-kernel - Re: [PATCH 1/9] exofs: osd Swiss army knife

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 31 Dec 2008 11:26:45 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	avishay@...il.com, jeff@...zik.org, viro@...IV.linux.org.uk,
	linux-fsdevel@...r.kernel.org, osd-dev@...n-osd.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] exofs: osd Swiss army knife

On Wed, 31 Dec 2008 17:33:41 +0200 Boaz Harrosh <bharrosh@...asas.com> wrote:

> Andrew Morton wrote:
> >> +int prepare_get_attr_list_add_entry(struct osd_request *req,
> >> +				    uint32_t page_num,
> >> +				    uint32_t attr_num,
> >> +				    uint32_t attr_len)
> >> +{
> >> +	struct osd_attr attr = {
> >> +		.page = page_num,
> > 
> > Kernel developers expect a field called "page" to have type `struct
> > page *'.  osd_attr.page is thus designed to confuse.
> > 
> >> ...
> >>
> > 
> 
> Rant below (can be ignored):
>   This single fix will cause a massive change to the open-osd
>   initiator patchset, (18 patches), and resubmission .I made the mistake
>   because this name originates from a file that all naming conventions
>   are taken from the OSD standard text. However this is no excuse
>   for using a well known Kernel construct name. I will fix it. And
>   will be more careful in the future.

The world wouldn't end if you left the code as-is.  We've done worse things :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/