linux-kernel - [PATCH] compile time warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Jan 2009 14:42:00 +0100
From:	ib@...peronline.de (Ingo Brueckl)
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] compile time warnings

Ingo Molnar <mingo@...e.hu> writes:

 > yes, with a small nit:
>>
>> +static inline void permanent_kmaps_init(pgd_t *pgd_base)
>> +{
>> +     (void) pgd_base;

 > there's no need for this line - this is not a macro, so the function
 > parameter does not have to be 'used'.

I live and learn.


fix compiler warning in arch/x86/mm/init_32.c

Signed-off-by: Ingo Brueckl <ib@...peronline.de>

--- linux-2.6.28/arch/x86/mm/init_32.c.orig	2008-12-25 00:26:37.000000000 +0100
+++ linux-2.6.28/arch/x86/mm/init_32.c	2009-01-02 14:21:18.000000000 +0100
@@ -436,8 +436,12 @@ static void __init set_highmem_pages_ini
 #endif /* !CONFIG_NUMA */

 #else
-# define permanent_kmaps_init(pgd_base)		do { } while (0)
-# define set_highmem_pages_init()	do { } while (0)
+static inline void permanent_kmaps_init(pgd_t *pgd_base)
+{
+}
+static inline void set_highmem_pages_init(void)
+{
+}
 #endif /* CONFIG_HIGHMEM */

 void __init native_pagetable_setup_start(pgd_t *base)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/