linux-kernel - Re: tip - Solution of ath9k: turn off temporarily (66b5c4a2c638b5a69d3e41abe4a2bae55035a92e)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Jan 2009 19:07:30 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
Cc:	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>, ath9k-devel@...ts.ath9k.org
Subject: Re: tip - Solution of ath9k: turn off temporarily
	(66b5c4a2c638b5a69d3e41abe4a2bae55035a92e)


* Jaswinder Singh Rajput <jaswinderlinux@...il.com> wrote:

> Hello Ingo,
> 
> If you choose :
> CONFIG_RFKILL=m
> CONFIG_ATH9K=y
> 
> It will give linking error because ATH9K need RFKILL functions.
> 
> But if you choose :
>  CONFIG_RFKILL=y
>  CONFIG_ATH9K=y
> 
> OR
> 
>  CONFIG_RFKILL=m
>  CONFIG_ATH9K=m
> 
> It is OK.

this was just a quick hatchet job to make the build regression go away. 
Would you like to send a real fix, with the wireless list and maintainers 
Cc-ed? Then i can revert the hack below from tip/out-of-tree.

	ngo

------------------>
>From 66b5c4a2c638b5a69d3e41abe4a2bae55035a92e Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Fri, 2 Jan 2009 16:04:03 +0100
Subject: [PATCH] ath9k: turn off temporarily

Impact: fix build failure

ath9k fails to build:

 drivers/built-in.o: In function `ath_detach':
 main.c:(.text+0x16720b): undefined reference to `rfkill_unregister'
 drivers/built-in.o: In function `ath_rfkill_poll':
 main.c:(.text+0x167801): undefined reference to `rfkill_force_state'
 drivers/built-in.o: In function `ath9k_start':
 main.c:(.text+0x167f01): undefined reference to `rfkill_register'
 main.c:(.text+0x167f11): undefined reference to `rfkill_free'
 drivers/built-in.o: In function `ath_pci_probe':
 main.c:(.text+0x169754): undefined reference to `rfkill_allocate'

when:

 CONFIG_RFKILL=m
 CONFIG_ATH9K=y
---
 drivers/net/wireless/ath9k/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath9k/Kconfig b/drivers/net/wireless/ath9k/Kconfig
index c43bd32..b849a45 100644
--- a/drivers/net/wireless/ath9k/Kconfig
+++ b/drivers/net/wireless/ath9k/Kconfig
@@ -1,6 +1,8 @@
 config ATH9K
 	tristate "Atheros 802.11n wireless cards support"
 	depends on PCI && MAC80211 && WLAN_80211
+	# build failures
+	depends on 0
 	select MAC80211_LEDS
 	select LEDS_CLASS
 	select NEW_LEDS
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/