lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Jan 2009 19:00:41 +0900 From: "KOSAKI Motohiro" <kosaki.motohiro@...fujitsu.com> To: "MinChan Kim" <minchan.kim@...il.com> Cc: "Mel Gorman" <mel@....ul.ie>, LKML <linux-kernel@...r.kernel.org>, linux-mm <linux-mm@...ck.org>, "Andrew Morton" <akpm@...ux-foundation.org>, "Nick Piggin" <npiggin@...e.de>, "wassim dagash" <wassim.dagash@...il.com> Subject: Re: [PATCH] mm: stop kswapd's infinite loop at high order allocation take2 > Hi, kosaki-san. > > I read the previous threads now. It's rather late :(. > > I think it's rather awkward that sudden big change of order from 10 to 0. > > This problem causes zone_water_mark's fail. > It mean now this zone's proportional free page per order size is not good. > Although order-0 page is very important, Shouldn't we consider other > order allocations ? > > So I want to balance zone's proportional free page. > How about following ? > > if (nr_reclaimed < SWAP_CLUSTER_MAX) { > if (order != 0) { > order -=1; > sc.order -=1; > } > } > > It prevents infinite loop and do best effort to make zone's > proportional free page per order size good. > > It's just my opinion within my knowledge. > If it have a problem, pz, explain me :) Please read Nick's expalin. it explain very kindly :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists