linux-kernel - Re: reiserfs broken with 2.6.28-17244-gb58602a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 3 Jan 2009 08:37:30 -1000
From:	"charles gagalac" <charles.gagalac@...il.com>
To:	"Al Viro" <viro@...iv.linux.org.uk>
Cc:	"Marc Koschewski" <marc@...nowledge.org>,
	Linux-LKLM <linux-kernel@...r.kernel.org>
Subject: Re: reiserfs broken with 2.6.28-17244-gb58602a

On Fri, Jan 2, 2009 at 3:23 AM, Al Viro <viro@...iv.linux.org.uk> wrote:
>
> Arrgh.  See if that helps:
>
> now that we use ih.key earlier, we need to do all its setup early enough
>
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
> diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
> index 145c2d3..1306d4f 100644
> --- a/fs/reiserfs/inode.c
> +++ b/fs/reiserfs/inode.c
> @@ -1782,6 +1782,12 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th,
>                goto out_bad_inode;
>        }
>        args.objectid = inode->i_ino = le32_to_cpu(ih.ih_key.k_objectid);
> +       if (old_format_only(sb))
> +               make_le_item_head(&ih, NULL, KEY_FORMAT_3_5, SD_OFFSET,
> +                                 TYPE_STAT_DATA, SD_V1_SIZE, MAX_US_INT);
> +       else
> +               make_le_item_head(&ih, NULL, KEY_FORMAT_3_6, SD_OFFSET,
> +                                 TYPE_STAT_DATA, SD_SIZE, MAX_US_INT);
>        memcpy(INODE_PKEY(inode), &(ih.ih_key), KEY_SIZE);
>        args.dirid = le32_to_cpu(ih.ih_key.k_dir_id);
>        if (insert_inode_locked4(inode, args.objectid,
> @@ -1834,13 +1840,6 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th,
>        reiserfs_init_acl_default(inode);
>        reiserfs_init_xattr_rwsem(inode);
>
> -       if (old_format_only(sb))
> -               make_le_item_head(&ih, NULL, KEY_FORMAT_3_5, SD_OFFSET,
> -                                 TYPE_STAT_DATA, SD_V1_SIZE, MAX_US_INT);
> -       else
> -               make_le_item_head(&ih, NULL, KEY_FORMAT_3_6, SD_OFFSET,
> -                                 TYPE_STAT_DATA, SD_SIZE, MAX_US_INT);
> -
>        /* key to search for correct place for new stat data */
>        _make_cpu_key(&key, KEY_FORMAT_3_6, le32_to_cpu(ih.ih_key.k_dir_id),
>                      le32_to_cpu(ih.ih_key.k_objectid), SD_OFFSET,
> --

the patch fixed the reiserfs problem for me.  thanks.

charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/