linux-kernel - Re: [PATCH] Winchiphead 340/1: full baud rate and status/control line support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 04 Jan 2009 11:19:21 +0100
From:	Tollef Fog Heen <tfheen@....no>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org, werner@...nelius-consult.de,
	frank@...gswood-consulting.co.uk
Subject: Re: [PATCH] Winchiphead 340/1: full baud rate and status/control line support

]] Alan Cox 

| Some niggles but this is a big improvement to the code.

Thanks.  New patch incoming RSN.

| >  static int ch341_set_baudrate(struct usb_device *dev,
| > +			      struct tty_struct *tty,
| >  			      struct ch341_private *priv)
| > +	baud = CH341_BAUDBASE_FACTOR / t1;
| > +
| > +	if (baud && tty)
| > +		tty_encode_baud_rate(tty, baud, baud);
| 
| Can you really get a speed below 1 baud ?

Unsure what you mean here?  Why would you ever end up with baudrates
below 1?

| > +	control = priv->line_control;
| > +	spin_unlock_irqrestore(&priv->lock, flags);
| > +
| > +	return ch341_set_handshake(port->serial->dev, control);
| > +}
| 
| This could race another set_handshake ? I'm not sure it matters and I'd
| suggest that stuff gets fixed after this is submitted separately

What's the easiest way to fix this?

-- 
Tollef Fog Heen
UNIX is user friendly, it's just picky about who its friends are
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/