lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 4 Jan 2009 02:54:15 -0600
From:	Milton Miller <miltonm@....com>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	linux-ppc <linuxppc-dev@...abs.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH

In-Reply-To: <20090103191359.GA9304@...ux.vnet.ibm.com>

Kamalesh Babulal wrote:
>  config SCSI_IBMVSCSI
>         tristate "IBM Virtual SCSI support"
> -       depends on PPC_PSERIES || PPC_ISERIES
> +       depends on (PPC_PSERIES || PPC_ISERIES) && VIOPATH
>         select SCSI_SRP_ATTRS
>         help
>           This is the IBM POWER Virtual SCSI Client

As VIOPATH is iSeries code and is only used by the iSeries code, the 
requirment should be

depends on PPC_PSERIES || (PPC_ISERIES && VIOPATH)

except VIOPATH isn't selectable:

arch/powerpc/platforms/iseries/Kconfig:

  config VIOPATH
         bool
         depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
         default y

so instead we should be adding

select VIOPATH if PPC_ISERIES

to SCSI_IBMVSCSI and just

select VIOPATH

to HVC_ISERIES as it depends on PPC_ISERIES

otherwise you have to enable one driver to get these other drivers.

milton

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ