linux-kernel - Re: 2.6.28: warn_slowpath in orinoco receive path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 Jan 2009 23:27:48 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Dave <kilroyd@...glemail.com>
CC:	Andrey Borzenkov <arvidjaar@...l.ru>,
	orinoco-devel@...ts.sourceforge.net,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: 2.6.28: warn_slowpath in orinoco receive path

On 01/05/2009 09:32 PM, Dave wrote:
> --- a/drivers/net/wireless/orinoco/orinoco.c
> +++ b/drivers/net/wireless/orinoco/orinoco.c
> @@ -1616,9 +1616,15 @@ static void orinoco_rx_isr_tasklet(unsigned long
> data)
> 
>         /* extract desc and skb from queue */
>         list_for_each_entry_safe(rx_data, temp, &priv->rx_list, list) {
> +               unsigned long flags;
> +
>                 desc = rx_data->desc;
>                 skb = rx_data->skb;
> +
> +               local_irq_save(flags);
>                 list_del(&rx_data->list);
> +               local_irq_restore(flags);
> +

Hi,

another processor still can see inconsistent state, spinlock should be taken.
Or, am I missing something?

regards,
--js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/