linux-kernel - Re: [patch] x86: make UV support optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Jan 2009 10:01:38 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Nick Piggin <npiggin@...e.de>
Cc:	Yinghai Lu <yinghai@...nel.org>, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	Cliff Wickman <cpw@....com>, Jack Steiner <steiner@....com>,
	Russ Anderson <rja@....com>
Subject: Re: [patch] x86: make UV support optional


* Nick Piggin <npiggin@...e.de> wrote:

> On Mon, Jan 05, 2009 at 10:38:17PM -0800, Yinghai Lu wrote:
> > On Mon, Jan 5, 2009 at 10:03 PM, Nick Piggin <npiggin@...e.de> wrote:
> > > UV is fairly rare.... and much of the support is already there to cope with
> > > 32-bit builds. So this makes sense I think.
> > >
> > > --
> > > Make X86 SGI Ultraviolet support configurable. Saves about 13K of text size
> > > on my modest config.
> > >
> > >   text    data     bss     dec     hex filename
> > > 6770537 1158680  694356 8623573  8395d5 vmlinux
> > > 6757492 1157664  694228 8609384  835e68 vmlinux.nouv
> > >
> > > Signed-off-by: Nick Piggin <npiggin@...e.de>
> > > ---
> > >  arch/x86/Kconfig                  |    7 +++++++
> > >  arch/x86/include/asm/genapic.h    |   24 ++++++++++++++++++++++++
> > >  arch/x86/include/asm/genapic_32.h |    7 -------
> > >  arch/x86/include/asm/genapic_64.h |    9 ---------
> > >  arch/x86/kernel/Makefile          |    5 +++--
> > >  arch/x86/kernel/entry_64.S        |    2 ++
> > >  arch/x86/kernel/genapic_64.c      |    3 ++-
> > >  arch/x86/kernel/io_apic.c         |    2 +-
> > >  8 files changed, 39 insertions(+), 20 deletions(-)
> > 
> > how about
> > kernel/efi.c:                   efi.uv_systab = config_tables[i].table;
> > ?
> 
> Good point, I missed that. Will resend a patch with that ifdef'ed 
> tomorrow unless any serious objections are raised.

Looks good to me, but please also extend the Makefile changes to 
kernel/tlb_uv.c, ./kernel/uv_sysfs.c, kernel/uv_irq.c, kernel/bios_uv.c - 
UV not just the genapic bits. Perhaps do it via gradual patches.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/