linux-kernel - Re: [PATCH 04/11] x86: cleanup remaining cpumask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 06 Jan 2009 07:25:46 -0800
From:	Mike Travis <travis@....com>
To:	Jaswinder Singh Rajput <jaswinderlinux@...il.com>
CC:	Jaswinder Singh Rajput <jaswinder@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jack Steiner <steiner@....com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/11] x86: cleanup remaining cpumask_t ops in smpboot
 code

Jaswinder Singh Rajput wrote:
> Hi Mike,
> 
> On Tue, Jan 6, 2009 at 7:32 PM, Mike Travis <travis@....com> wrote:
>> I'll look closer but I had assumed that these masks would not be
>> used for UP configurations (it did not get any compile errors
>> with the allnoconfig).  In fact, any access to these masks for
>> UP would be unnecessary since there are no callouts, the boot
>> cpu is assumed initialized, and it has no siblings.  So the
>> masks are specific to SMP.
>>
> 
> If it is specific to SMP then:
> CONFIG_X86_64 should be CONFIG_X86_64_SMP
> CONFIG_X86_32 should be CONFIG_X86_32_SMP
> 
> I am in the process of cleaning smp.h and moving out non-smp from
> smp.h as per Ingo's suggestion.
> 
> I am planning to move cpumask related things to asm/cpumask.h
> 
> Is this OK to you.
> 
> --
> JSR

It's fine with me, anything to untangle the web we've weaved... ;-)

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/