linux-kernel - Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 6 Jan 2009 17:40:06 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	Milton Miller <miltonm@....com>,
	linux-ppc <linuxppc-dev@...abs.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH

On Tue, Jan 06, 2009 at 09:27:24PM +0530, Kamalesh Babulal wrote:
> * Sam Ravnborg <sam@...nborg.org> [2009-01-06 11:46:19]:
> 
> > Hi Kamalesh
> > 
> > Looks good, small nit below.
> > 
> > >  config VIOPATH
> > >  	bool
> > > -	depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
> > > -	default y
> > > +	default n
> > 
> > As 'n' is default anyway this line is not needed and I suggest you
> > spin a final version of the patch with this removed.
> > 
> > 	Sam
> 
> Hi Sam,
> 
> 	Thanks for the review comments. I am resending the patch with the changes
> you have recommended.
> 
> Impact: Fix the VIOPATH dependency in the iSeries dependent drivers.
> 
> iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled.
> Removing the dependency of VIOPATH by selecting it, when the drivers
> dependent on iSeries code.
> 
> Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Reviewed-by: Sam Ravnborg <sam@...nborg.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/