linux-kernel - confusing checkpatch.pl messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 06 Jan 2009 21:57:36 +0100
From:	Németh Márton <nm127@...email.hu>
To:	Andy Whitcroft <apw@...dowen.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Joel Schopp <jschopp@...tin.ibm.com>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: confusing checkpatch.pl messages

Hi,

I run the checkpatch.pl against the attache file and it reported some
confusing warning and error messages. The attached file has an obsoleted
syntax:

>From "info gcc", Chapter 5.21 "Designated Initializers":
>  In a structure initializer, specify the name of a field to initialize
> with `.FIELDNAME =' before the element value.  For example, given the
> following structure,
>
>      struct point { int x, y; };
>
> the following initialization
>
>      struct point p = { .y = yvalue, .x = xvalue };
>
> is equivalent to
>
>      struct point p = { xvalue, yvalue };
>
>  Another syntax which has the same meaning, obsolete since GCC 2.5, is
> `FIELDNAME:', as shown here:
>
>     struct point p = { y: yvalue, x: xvalue };

However, the checkpatch.pl speaks about labels, which are incorrect, I think:
> $ /usr/src/linux/scripts/checkpatch.pl --file test.c
> WARNING: labels should not be indented
> #5: FILE: test.c:5:
> +       open: test_open,
>
> ERROR: spaces required around that ':' (ctx:VxW)
> #6: FILE: test.c:6:
> +       release: test_close,
>                ^
>
> WARNING: labels should not be indented
> #6: FILE: test.c:6:
> +       release: test_close,
>
> ERROR: spaces required around that ':' (ctx:VxW)
> #7: FILE: test.c:7:
> +       ioctl: test_ioctl,
>              ^
>
> WARNING: labels should not be indented
> #7: FILE: test.c:7:
> +       ioctl: test_ioctl,
>
> total: 2 errors, 3 warnings, 9 lines checked
>
> test.c has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.

Regards,

	Márton Németh

View attachment "test.c" of type "text/x-csrc" (141 bytes)