linux-kernel - Re: [PATCH v7 0/8] Tunable sched_mc_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 07 Jan 2009 09:59:15 +0100
From:	Mike Galbraith <efault@....de>
To:	balbir@...ux.vnet.ibm.com
Cc:	svaidy@...ux.vnet.ibm.com, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v7 0/8] Tunable sched_mc_power_savings=n

I have a couple questions if you don't mind.

In wake_idle() there's an odd looking check for kthreads.  Why does it
matter if a kbuild task wakes kernel or userland helper thread?

I also don't see why sched_mc overrides domain tunings.  You can turn
NEWIDLE off and sched_mc remains as set, so it's a one-way override.  If
NEWIDLE is a requirement for sched_mc > 0, it seems only logical to set
sched_mc to 0 if the user explicitly disables NEWIDLE.

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/