linux-kernel - Re: RFC: Fix f_flags races without the BKL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 Jan 2009 15:03:54 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Jonathan Corbet <corbet@....net>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andi Kleen <andi@...stfloor.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Al Viro <viro@...IV.linux.org.uk>, bfields@...ldses.org
Subject: Re: RFC: Fix f_flags races without the BKL

On 01/09, Jonathan Corbet wrote:
>
> On Fri, 9 Jan 2009 11:08:21 +0100
> Oleg Nesterov <oleg@...hat.com> wrote:
>
> > and then we change f_flags again, including F_ASYNC bit.
> >
> > This is racy?
>
> No, I took FASYNC out of SETFL_MASK, so it isn't changed here.

Ah yes, I missed the change in SETFL_MASK. Thanks.

> > Now we have the global mutex for ->fasync... Well, not very
> > good but fasync_helper() takes fasync_lock anyway.
>
> Not very good, but does anybody know of a workload which would result in
> that mutex being contended ever?

I don't.

Actually, I personally dislike the global file_flags_lock more.
But don't get me wrong, I do not think O_LOCK_FLAGS is better
or cleaner.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/