linux-kernel - Re: [PATCH] driver core: Convert '/' to '!' in dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Jan 2009 07:30:24 +0100
From:	Kay Sievers <kay.sievers@...y.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Jens Axboe <jens.axboe@...cle.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver core: Convert '/' to '!' in dev_set_name()

On Sat, Jan 10, 2009 at 07:27, Roland Dreier <rdreier@...co.com> wrote:
> Commit 3ada8b7e ("block: struct device - replace bus_id with dev_name(),
> dev_set_name()") deleted the code in register_disk() that changed a '/'
> to a '!' in the device name when registering a disk, but dev_set_name()
> does not perform this conversion.
>
> This leads to amusing problems with disks that have '/' in their names:
> for example a failure to boot with the root partition on a cciss device,
> even though the kernel says it knows about the root device:
>
>    VFS: Cannot open root device "cciss/c0d0p6" or unknown-block(0,0)
>    Please append a correct "root=" boot option; here are the available partitions:
>    6800        71652960 cciss/c0d0 driver: cciss
>      6802               1 cciss/c0d0p2
>      6805         2931831 cciss/c0d0p5
>      6806        34354908 cciss/c0d0p6
>    6810        71652960 cciss/c0d1 driver: cciss
>
> Fix this by adding code to change '/' to '!' in dev_set_name() to handle
> this until dev_set_name() is converted to use kobject_set_name().

Great! Thanks a lot for fixing this,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/