linux-kernel - Re: [PATCH -tip] coda_psdev.h: extern's make no sense in userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 12 Jan 2009 23:22:03 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Jaswinder Singh Rajput <jaswinder@...radead.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	sam@...nborg.org, LKML <linux-kernel@...r.kernel.org>,
	gorcunov@...il.com
Subject: Re: [PATCH -tip] coda_psdev.h: extern's make no sense in userspace

On Tue, 2009-01-13 at 12:06 +0530, Jaswinder Singh Rajput wrote:
> Impact: fix make headers_check warning:
> 
>  usr/include/linux/coda_psdev.h:90: extern's make no sense in userspace
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  include/linux/coda_psdev.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/coda_psdev.h b/include/linux/coda_psdev.h
> index 07ae8f8..c620958 100644
> --- a/include/linux/coda_psdev.h
> +++ b/include/linux/coda_psdev.h
> @@ -87,6 +87,8 @@ struct upc_req {
>   * Statistics
>   */
>  
> +#ifdef __KERNEL__
>  extern struct venus_comm coda_comms[];
> +#endif /* __KERNEL__ */

As this only gets used in code/inode.c, coda/psdev.c it would be nice if
a code-internal header could be found that could hold this.

This is only here due to the one use outside of psdev.c in inode.c

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/